AccessCheckInterface and AccessStorageInterface are useless. They have been invented for some "playing around" with interfaces. There is no benefit from them. The related methods in AccessCheck and AccessStorage need updated comments afterwards along with removed interfaces, of course.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | ThrowInterfaces-2899428-14.patch | 17.81 KB | prathibhab.cdac |
| #12 | ThrowInterfaces-2899428-12.patch | 8.99 KB | skll5l |
| #9 | ThrowInterfaces-2899428-9.patch | 9.04 KB | skll5l |
| #5 | ThrowInterfaces-2899428-5.patch | 21.35 KB | prathibhab.cdac |
| #3 | AccessCheckInterface.patch | 2.92 KB | prathibhab.cdac |
Comments
Comment #2
prathibhab.cdac commentedUnable to find AccessStorageInterface in Drupal 8.
Comment #3
prathibhab.cdac commentedPlease find the patch for removing the AccessCheckInterface.
Comment #4
jepster_You have removed a Drupal core interface. That is very wrong. This will break the entire Drupal system and is not related to the Permissions by Term module. Permissions by Term module is located in it's own project folder. You are lacking basic understand of Drupal.
Install Drupal, try to understand how the system works. Especially the folder structure. Documentation about the directory structure can be found at https://www.drupal.org/docs/8/understanding-drupal/directory-structure.
I suggest you, to get familiar with Drupal itself. A few good resources can be books. Like these:
Comment #5
prathibhab.cdac commentedComment #6
prathibhab.cdac commentedHow to test after removing these interfaces?
Comment #7
prathibhab.cdac commentedAccessCheckInterface appears in PermissionsByTermController class. Its used in handleviews and handlenode funtion. How to handle this part?
Comment #8
jepster_As already written to you at https://www.drupal.org/node/2818105 and via IRC. I will tell you again and again:
@prathibhab.cdac: Just replace the parameter hinting with the class instead of it's interface. That's easy, since there is only 1 interface per 1 class.
Take a look at https://www.drupal.org/docs/8/modules/permissions-by-term and scroll down to "Testing" section.
Comment #9
skll5l commentedSee attached. Unit tests and most of your example Behat tests are successful. The first scenario fails; I don't think it's related.
Comment #10
jepster_@Sebastian Kamil (sebkamil): Thanks for your patch! I will review it asap.
Comment #11
jepster_Could you please re-base your patch against the latest dev-version?
Comment #12
skll5l commentedRebased on the latest 8.x-1.x
Had one conflict. Resolved it by taking 8.x-1.x version
Comment #13
jepster_Thanks. Please mind that the interface-classes are containing doc-blocks with comments. These comments must be preserved. The @inheritdoc comment block works only with a corresponding interface. Since we have no interface anymore, the method comment must be moved from the interface to the corresponding class method.
Comment #14
prathibhab.cdac commentedComments added under the respective class method.
Comment #16
jepster_Thanks! I have tweaked the changes a bit (typos, useless comments, spaces..) and commited it into the dev branch. Will come soon into next release (version 8.x-1.24).
Comment #17
jepster_@prathibhab.cdac + @sebkamil: If you like to contribute, please take care of this issue: Automated Tests