Currently, the tests for 8.x-3.x-dev branch are broken. As a result, no patches can be added.

CommentFileSizeAuthor
#2 simplesamlphp_auth-edit_fix_tests_for-2898517-2.patch2.63 KBidebr

Comments

gargsuchi created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new simplesamlphp_auth-edit_fix_tests_for-2898517-2.patch2.63 KB

Attached patch fixes the failing tests. The code was partially from #2907182: Admin UI Pages not Accessible via Permission by kerasai, so credit where credit is due.

dakku’s picture

dakku commented

Thank you for the patch Ide, I will hopefully get a chance to review and test over the weekend.

dakku’s picture

dakku commented

Hi Ide,
At a quick glance, I couldnt quite figure out how the changes to simplesamlphp_auth.schema.yml are related to the test?

idebr’s picture

idebr commented

Hi dakku,

Every KernelTest and SimpleTest call the ConfigSchemaChecker in the setup function. This class checks the configuration that is added in /config/install with the configuration schema in /config/schema. Any mismatch in data type then results in an error in the automated tests.

  • dakku committed 10c7e35 on 8.x-3.x authored by idebr 
    Issue #2898517 by idebr: Fix Tests for 8.x-3.x-dev branch

dakku credited kerasai.

dakku’s picture

dakku commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.