This is a follow-up issue of #2893855: Add support for asciidoctor.
Support for asciidoctor command was added in the issue above. But currently asciidoctor command is used only if asciidoc command is not available. Site admins cannot select which command to use among them.
It would be better if site admins can select the command used for each filter if the server provides 2 commands: asciidoc and asciidoctor.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2895609-2-without-options.png | 34.21 KB | hgoto |
| #2 | 2895609-2-with-options.png | 43.27 KB | hgoto |
| #2 | asciidoc-add_filter_options-2895609-2.patch | 4.28 KB | hgoto |
Comments
Comment #2
hgoto commentedHere is a patch and captures after the patch is applied.
In the patch, I also tried to organize the methods of Asciidoc. I changed the static method to a instance method and changed the visibility. I'd like this to be reviewed :)
Comment #3
hgoto commentedComment #5
marvil07 commentedThanks for the patch!
I have just changed the order of the methods to move
getAsciidoc()back to the top, which reduces the diff.Code is now part of 8.x-1.x.
I will be realising a new version tomorrow.
@hgoto If you are interested, I can give you access to the repository and you can become co-maintainer.
Comment #6
hgoto commentedThanks!
And thank you for your suggestion. I'd like to be a co-maintainer if you don't mind :)
Comment #7
marvil07 commented@hgoto, you now have maintainer access to the project, welcome!
BTW I did a new point release containing latest changes, 8.x-1.1.
Comment #8
hgoto commented@marvil07, thank you very much!