Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There are some coding standard issues in this module.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | email_token_coding_standard-2895308-3.patch | 8.81 KB | Deepthi kumari |
| #2 | email_token_coding_standard-2895308-2.patch | 8.8 KB | jayesh_makwana |
| email_token.txt | 11.91 KB | jayesh_makwana |
Issue fork email_token-2895308
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2895308-coding-standard-issues
changes, plain diff MR !7
Comments
Comment #2
jayesh_makwana commentedWe created a patch for solving coding standard issues for this module. Please check and apply it.
Comment #3
Deepthi kumari commentedPatch looks good. Found below issues.
FILE: E:\Xampp\htdocs\drupal-8.8.1\modules\contrib\email_token\email_token.tokens.inc
-------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
46 | WARNING | [ ] Unused variable $token_service.
50 | WARNING | [ ] Unused variable $langcode.
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: E:\Xampp\htdocs\drupal-8.8.1\modules\contrib\email_token\src\Plugin\Filter\EmailToken.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
27 | WARNING | [ ] Variable $options is undefined.
28 | WARNING | [ ] Variable $options is undefined.
38 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
Fixed the t() call issue and left the unused variables for future use.
Updated the patch. Please review.
Comment #4
shashwat purav commentedHello @Deepthi kumari, please provide interdiff file as well.
Comment #5
akshay kashyap commented@Deepthi kumari
Thanks for the Patch but i am not able to apply the patch successfully get some error message during applying the patch please check.
Comment #7
shiv_sharma commentedCreated a new patch with latest code. no new warning from phpcs
Comment #8
akshay kashyap commentedI have created MR to fix the drupal coding standard issue Please review.
Thank you.
Comment #9
shiv_sharma commentedComment #10
nishantVerified patch#7 working fine for me.
Comment #13
rajan kumar commentedthank you everyone for provide patch OR test that patch.
I have committed #7 patch in latest version of module.
Comment #14
rajan kumar commented