references.feeds.inc
----------------------------------------------------------------------
FOUND 43 ERRORS AND 26 WARNINGS AFFECTING 62 LINES
----------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
   4 | WARNING | [ ] Line exceeds 80 characters; contains 97
     |         |     characters
   6 | WARNING | [ ] Line exceeds 80 characters; contains 98
     |         |     characters
   7 | ERROR   | [x] Doc comment long description must end with a
     |         |     full stop
   9 | ERROR   | [x] Additional blank lines found at end of doc
     |         |     comment
  33 | ERROR   | [ ] Missing parameter type
  35 | ERROR   | [ ] Missing parameter type
  37 | ERROR   | [ ] Missing parameter type
  39 | ERROR   | [x] Separate the @param and @return sections by a
     |         |     blank line.
  56 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for
     |         |     xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
  56 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
  58 | ERROR   | [x] Trailing punctuation for @see references is not
     |         |     allowed.
  66 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  69 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  72 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  75 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  78 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  81 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  84 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  87 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  90 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  93 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  96 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  99 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 102 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 105 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 108 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 111 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 114 | ERROR   | [x] Expected 1 blank line after function; 0 found
 116 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for
     |         |     xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
 116 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
 118 | ERROR   | [x] Trailing punctuation for @see references is not
     |         |     allowed.
 120 | ERROR   | [x] Additional blank lines found at end of doc
     |         |     comment
 127 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 129 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 130 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 133 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 136 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 139 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 142 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 145 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 148 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 151 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 154 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 157 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 160 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 163 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 166 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 169 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 172 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 178 | ERROR   | [x] Doc comment short description must end with a
     |         |     full stop
 182 | ERROR   | [ ] Missing parameter type
 184 | ERROR   | [ ] Missing parameter type
 186 | ERROR   | [ ] Missing parameter type
 188 | ERROR   | [ ] Missing parameter type
 201 | WARNING | [ ] Line exceeds 80 characters; contains 85
     |         |     characters
 203 | ERROR   | [ ] sizeof() is a function name alias, use count()
     |         |     instead
 212 | WARNING | [ ] Line exceeds 80 characters; contains 81
     |         |     characters
 212 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, colons, question marks, or
     |         |     closing parentheses
 247 | ERROR   | [x] Expected 1 space before "="; 0 found
 252 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 252 | ERROR   | [ ] Concatenating translatable strings is not
     |         |     allowed, use placeholders instead and only one
     |         |     string literal
 271 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 271 | ERROR   | [ ] Concatenating translatable strings is not
     |         |     allowed, use placeholders instead and only one
     |         |     string literal
 271 | ERROR   | [x] Concat operator must be surrounded by a single
     |         |     space
 277 | ERROR   | [x] Inline comments must start with a capital letter
 278 | ERROR   | [x] There should be no white space before a closing
     |         |     ")"
 283 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 283 | ERROR   | [ ] Concatenating translatable strings is not
     |         |     allowed, use placeholders instead and only one
     |         |     string literal
----------------------------------------------------------------------
PHPCBF CAN FIX THE 32 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


----------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
----------------------------------------------------------------------
  97 | WARNING | [ ] Line exceeds 80 characters; contains 110
     |         |     characters
  99 | ERROR   | [ ] Missing parameter type
 102 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 127 | ERROR   | [ ] Missing parameter type
 129 | ERROR   | [ ] Missing parameter type
 131 | ERROR   | [ ] Missing parameter type
 133 | ERROR   | [ ] Missing parameter type
 135 | ERROR   | [ ] Missing parameter type
 142 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 160 | ERROR   | [x] Expected 1 space after IF keyword; 2 found
 172 | ERROR   | [ ] Inline doc block comments are not allowed; use
     |         |     "/* Comment */" or "// Comment" instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one
   |       |     blank line
 4 | ERROR | [x] Function comment short description must start with
   |       |     exactly one space
 4 | ERROR | [x] Doc comment short description must end with a full
   |       |     stop
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
CommentFileSizeAuthor
#4 After.png31.24 KBrenatog
#4 Before.png30.19 KBrenatog
#4 code_review_-2892787-2.patch18.09 KBrenatog

Comments

RenatoG created an issue. See original summary.

renatog’s picture

In attachment the patch with fix.

Before:

After:

In additional; I fixed all Coding Standards.

Thanks

  • RenatoG committed b82cc47 on 7.x-2.x
    Issue #2892787 by RenatoG: [Code Review] Translatable strings must not...
renatog’s picture

Status: Active » Fixed
StatusFileSize
new18.09 KB
new30.19 KB
new31.24 KB

Fixed.

Commited in dev branch.

Regards

renatog’s picture

Issue tags: +code-review

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.