Because this module provides most of its core functionality without relying on Context, Context should be removed as a dependency. Its functionality can still be invoked in third_party_wrappers_init() if context is enabled.

CommentFileSizeAuthor
#6 third_party_wrappers-remove_context_dependency-2892438-6-7.patch868 bytesalexdmccabe
#4 third_party_wrappers-2892438-4-remove-context-dependency.patch978 bytesdaniel_j
#2 third_party_wrappers-remove_context_dependency-2892438-2.patch881 bytesdaniel_j

Comments

daniel_j created an issue. See original summary.

daniel_j’s picture

daniel_j commented
StatusFileSize
new third_party_wrappers-remove_context_dependency-2892438-2.patch881 bytes
daniel_j’s picture

daniel_j commented
Status: Active » Needs review
daniel_j’s picture

daniel_j commented
StatusFileSize
new third_party_wrappers-2892438-4-remove-context-dependency.patch978 bytes

This version of the patch applies cleanly to the dev version of the module (as opposed to the git-cloned version).

Status: Needs review » Needs work

The last submitted patch, 4: third_party_wrappers-2892438-4-remove-context-dependency.patch, failed testing. View results

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
StatusFileSize
new third_party_wrappers-remove_context_dependency-2892438-6-7.patch868 bytes

Not sure why it wasn't applying, but I redid it by hand, and tweaked it slightly to use module_exists instead of function_exists.

Not attaching an interdiff because it failed to apply, so it also failed to produce an interdiff.

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Status: Needs work » Needs review

  • alexdmccabe committed 4a0f527 on 7.x-1.x authored by daniel_j 
    Issue #2892438 by daniel_j, alexdmccabe: Remove hard dependency on...
alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Status: Needs review » Fixed

Sorry for the slow reply. Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.