Release coordination issue for 2.0.0

Converting this issue to release co-ordination. (Is there a hyphen?)

Please give feedback from your use here, and we can work towards an official release :)

I can't select 8.x-1.x-dev yet but will when the tarball drops.

Hey Gareth,

I set up a test booking site with commerce_dps_pxpay enabled.
However, on submitting a payment the site gets stuck in an infinite loop and never arrives at the DPS payment page.

Steps to reproduce the issue:
- add developer acc to the UI plus with enable logging for development mode (tried with both server options "PX Pay" and "PX Pay 2.0"
- submitted a test payment
- payment page gets stuck in an infinite loop and never redirects to DPS site

Drupal logs:

Unable to generate DPS request with settings: Array ( [commerce_dps_pxpay_userid] => DEV_ACCOUNT_NAME [commerce_dps_pxpay_key] => secret-auth-key [commerce_dps_pxpay_server] => https://sec.paymentexpress.com/pxaccess/pxpay.aspx [commerce_dps_pxpay_currency] => NZD [commerce_dps_pxpay_cancel_return_url] => cart [commerce_dps_pxpay_refprefix] => Booking Reference [commerce_dps_pxpay_log_transactions] => 1 [cancel_return] => http://SITENAME/checkout/7/payment/back/dP-kDbFUUkfc2ZO4CD3V49vlclRCqv7Jy7kXr2nFgbw [return] => http://SITENAME/checkout/7/dps_pxpay_fprn/dP-kDbFUUkfc2ZO4CD3V49vlclRCqv7Jy7kXr2nFgbw [payment_method] => commerce_dps_pxpay|commerce_payment_commerce_dps_pxpay )

I noted in an email from DPS recently that the version/URL was
PxPay2.0 - URL: https://uat.paymentexpress.com/pxaccess/pxpay.aspx
If that's of any use?

Let me know if there's anything else I can provide or if there is something being overlooked :)

/K

@snlnz, thanks for testing!

So - some DPS test accounts use https://sec, and some use https://uat ... how that is assigned is not clear. This means that people really need to be able to configure their endpoint URL as well as their credentials.

It does mean that we need to make the setting clear where we expose it (IMO we should use "Endpoint URL" rather than "Test/Live Mode" as labels, because the latter doesn't match how it actually works).

I don't have a live test install handy - is there such a setting? If not, do you want to add one? Patch welcome here, PRs welcome https://github.com/xurizaemon/commerce_dps/tree/8.x-1.x or at Gareth's repo above.

I've reached out to DPS asking how test accounts are assigned their endpoint URL prefixes but I think you're right, if this is not consistently assigned, the UI will require an editable endpoint URL field to change.

On a live test install, there is no such setting I can confirm that but I'll have a look at the code and provide more feedback as soon as I can.

Regardless of their logic, we know that two people (myself, Gareth) have https://sec.paymentexpress.com endpoints for dev, and I know of two more (you, Eileen) who have https://uat.paymentexpress.com endpoints for dev tokens. So ... yeah, we definitely need that as a config :)

I've discussed with them before (possibly an issue in the queue here has details) and they know it's not consistent, I *think* it's just historic (Gareth & I showing our account age?)

For sure and judging by the time it's taken for them to respond, I figure they already know what I'm asking. *sigh*

Tagging in #2934276: Installing commerce_dps via composer fails [won't fix]

Have released a beta1 @ https://www.drupal.org/project/commerce_dps/releases/8.x-1.0-beta1

Well, 8.x-1.0 never got released, let's just move this issue over to the 2.0.0 release shall we?

At this point I recommend moving to 2.0.x as it has various fixes. Since 8.x-1.0-beta1 was beta1, I'll release 2.0.0-beta2 now. It's mostly the same :)

For 2.0.0 I'd like to see #3206147: Verify PxPay iframe integration behaviour fixed at least ... that may just be a configuration issue my side, haven't yet looked.

Based on 8.x-1.0-beta1, with the following fixes to be included:

• #3205994: "Unexpected error" at checkout if gateway misconfigured
• #3146476: Drupal 9 readiness
• #3157616: omnipay/paymentexpress:~3.0
• #3206147: Verify PxPay iframe integration behaviour

Ugh, that was meant to go into the issue summary :D

Released :)

- https://www.drupal.org/project/commerce_dps/releases/2.0.0