There are some coding standard issues in module.

CommentFileSizeAuthor
#4 shutdown_coding_standard-2887674-4.patch15.65 KBjayesh_makwana
#2 shutdown_coding_standard-2887674-2.patch15.31 KBjayesh_makwana
shutdown.txt4.9 KBjayesh_makwana

Comments

jayesh_makwana created an issue. See original summary.

jayesh_makwana’s picture

jayesh_makwana commented
StatusFileSize
new shutdown_coding_standard-2887674-2.patch15.31 KB

We create a patch for solving coding standard issues for this module. Please check and apply it.

ludo.r’s picture

ludo.r
Location Brussels
commented

Hello,

Thanks for raising this issue.

I tried the patch but it doesn't apply:

error: patch failed: shutdown.admin.inc:1
error: shutdown.admin.inc: patch does not apply
error: patch failed: shutdown.module:1
error: shutdown.module: patch does not apply

Did you do it based on dev version?

I'd be happy to commit it if you provide a new patch.

jayesh_makwana’s picture

jayesh_makwana commented
StatusFileSize
new shutdown_coding_standard-2887674-4.patch15.65 KB

@dolu

Hello,

Sorry for interrupt in patch. Actually, I create a updated patch. It's work properly. Just one issue not solved. It mention below,
"The second argument to watchdog() should not be enclosed with t()" in module file. Because i do not know about watchdog errors. I will read about this later. Thanks for your feedback.

Thank you.

  • dolu committed b622200 on 7.x-1.x 
    Issue #2887674 by jayesh_makwana: Coding Standard issues
ludo.r’s picture

ludo.r
Location Brussels
commented
Status: Active » Fixed

This has been fixed now, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.