Closed (fixed)
Project:
CKEditor IndentBlock
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Jun 2017 at 06:42 UTC
Updated:
20 Oct 2017 at 00:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hkirsman commentedI checked numerous contrib modules and most of them didn't have any requirements and none of them had requirement for Drupal. So this is my first try with some other fixes to the composer.json.
This is also not correct:
Didn't have time to dig deep but here's what my editor is saying to read: https://getcomposer.org/doc/faqs/why-are-unbound-version-constraints-a-b...
Comment #3
hkirsman commentedCurrently I added this to my own composer to get the project downloaded:
And then:
Also I would suggest more strict html filter. So instead of
<p class>it would be<p class="Indent*">Comment #4
gnugetI'm going to move this to "major" because this prevents the module to being installed.
Thanks for the workaround
Comment #5
meichr commented@hkirsman, thanks for the patch and workaround. The wrong links are a leftover from, when the module was in a sandbox.
The require drupal 8.1.0 intended to prevent an installation of this module under Drupal 8.0.* as some functionality requires at least Drupal 8.1.0.
@gnuget, @hkirsman, do you see a replacement for this part to have this check implemented? This is the only piece, why the suggested patch has not been committed.
Thanks for your insight.
Comment #6
gnugetTry just removing the 8. something like:
That should do the trick.
Comment #7
gnugetOr maybe the problem is the name of the package it should be
drupal/coreNOTdrupal/drupalSo you can try this instead:
I think that should work.
I just attached a patch with this change.
Comment #8
meichr commentedThank you, @gnuget, great!
On a final check, I found that also the issue link was still the one by the sandbox, I'm adding this change to the patch before committing it.
Comment #10
meichr commentedTested by creating a drupal project using
Result: Drupal project and contributed module ckeditor_indentblock have been downloaded; ckeditor_indentblock was added to composer.json.
=> Fixed.