Integration of new YouTube API version with Media YouTube module.

CommentFileSizeAuthor
#7 youtube_upgrade_2410027_7.patch7.45 KBjoseph.olstad
#6 youtube_upgrade_2410027_0.patch7.36 KBjoseph.olstad
#2 youtube_upgrade_2410027.patch7.72 KBankitsingh0188

Comments

ankit.singh created an issue. See original summary.

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
StatusFileSize
new youtube_upgrade_2410027.patch7.72 KB

Hi,

I have created a patch for that and test it.
Please find the attached patch. The patch search the youtube videos accordingly

Note : You can add the YouTube API Url and API Key from here : admin/config/media/media-youtube

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Hi Ankit.singh , sorry I could not try your code, your patch does not apply on the media_youtube 7.x-3.x branch , does your patch depend on some other patches?

according to your patch there is a file called js/media-youtube.browser.js
however I do not see this file in the 7.x-3.x branch

also, it appears you've made the patch against profiles/ttrybe ....
the correct way to make a patch is by cloning the project, in this case media_youtube , applying your code changes and then capturing the changes as you normally would using git diff for example.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

ah , sorry , just noticed that the patch was for the 7.x-2.x branch , makes sense, however the patch needs reroll anyway, its not formatted correctly

joseph.olstad’s picture

joseph.olstad
Primary language French
commented 
checking file js/media-youtube.browser.js
Hunk #1 FAILED at 25.
1 out of 2 hunks FAILED
checking file media_youtube.module
Hunk #2 succeeded at 107 (offset 9 lines).
Hunk #3 FAILED at 142.
Hunk #4 succeeded at 364 (offset 6 lines).
Hunk #5 succeeded at 435 (offset 6 lines).
1 out of 5 hunks FAILED
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new youtube_upgrade_2410027_0.patch7.36 KB

here is a copy verbatim of your patch, minus the profiles/ttrybe junk
still needs fixing though

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new youtube_upgrade_2410027_7.patch7.45 KB

new patch

  • joseph.olstad committed 5a4ce1b on 7.x-2.x 
    Issue #2883216 by joseph.olstad, ankit.singh: Youtube API Upgrade...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

As far as my tests see, this is fixed in the 7.x-2.x dev branch, however you may want to upgrade to 7.x-3.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.