Method validId is not testable because the method is static.
The limited support in phpunit for stubbing and mocking static methods has been removed in phpunit 4.0
https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-f...
Make the method validId non static.
The method validId cannot be called directly anymore, the object needs to be instantiated first.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | project-media_youtube-2879430-6-7.54.patch | 970 bytes | jacobfrancke@gmail.com |
| #2 | project-media_youtube-2879430-1-7.54.patch | 1.23 KB | jacobfrancke@gmail.com |
Comments
Comment #2
jacobfrancke@gmail.com commentedHere is the patch.
Comment #3
joseph.olstadfixed in 7.x-3.x dev branch
Comment #6
jacobfrancke@gmail.com commentedHi Joseph,
In the new release 3.1.0 the parse function has some more function calls to self::validID, because there was another patch from somebody else which added this.
Here is a new patch which fixes these calls to. Thanks for commiting this.
Comment #7
jacobfrancke@gmail.com commentedComment #9
joseph.olstadwaiting to see what the testbot says
Could you by chance resolve or find a solution to this issue:
#2883644: Fix head tests for media_youtube 7.x-3.1
Comment #10
joseph.olstadno change to the test results.