We should not use db_() in the code base as it is depreciated

CommentFileSizeAuthor
#12 super_login-forgotten-use-statement-2872867-12.patch331 bytesrhristov
#9 super_login-replace-db-calls-2872867-9.patch1.91 KBrhristov
#6 2872867-6.patch2.03 KBrhristov
#2 2872867-2.patch1.23 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new 2872867-2.patch1.23 KB

Applying the patch, please review.

amit.drupal’s picture

amit.drupal commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. All the db_query removed from All files.

3cwebdev’s picture

3cwebdev commented

Thanks for the patch. Committed.

rhristov’s picture

rhristov commented
StatusFileSize
new 2872867-6.patch2.03 KB

Applying patch that change the queries from static to dynamic. It is needed because the module is not working together with modules like DataBase Email Encryption, which are altering the queries.

rhristov’s picture

rhristov commented
Status: Reviewed & tested by the community » Needs review
3cwebdev’s picture

3cwebdev commented

@rhsistov, thank you for the patch but it is not applying to the DEV snapshot. Wss the patch created off of DEV?

rhristov’s picture

rhristov commented
StatusFileSize
new super_login-replace-db-calls-2872867-9.patch1.91 KB

@quantumized it was not. Attaching a patch for the dev version.

  • quantumized committed c6a6da9 on 8.x-1.x authored by rhristov 
    Issue #2872867 by rhristov, Pavan B S: Replace all calls to db_(), which...
3cwebdev’s picture

3cwebdev commented

Thank you. Patch applied to DEV.

rhristov’s picture

rhristov commented
StatusFileSize
new super_login-forgotten-use-statement-2872867-12.patch331 bytes

@quantumized for the patch against dev version I have forgotten the use statement. Applying another patch that adds the statement.

  • quantumized committed 4b75318 on 8.x-1.x authored by rhristov 
    Issue #2872867 by rhristov, Pavan B S, quantumized: Replace all calls to...
3cwebdev’s picture

3cwebdev commented

New patch has been applied to DEV.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Fixed

fixed?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.