EntityManager should not be used in code base.

CommentFileSizeAuthor
#3 removing_deprecated-2870304-3.patch5.38 KByogeshmpawar
#2 2870304-2.patch5.57 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new 2870304-2.patch5.57 KB

Applying the patch, please review.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new removing_deprecated-2870304-3.patch5.38 KB

Updated patch with more changes & also previous patch failed to apply.

+++ b/src/Form/BetterFieldDescriptionsFieldsForm.php
@@ -146,14 +146,14 @@ class BetterFieldDescriptionsFieldsForm extends ConfigFormBase {
+      $extra_fields = $this->entityTypeManager->getExtraFields('node', $bundle_machine_name, 'form');

This statement causes fatal error, i think you have not tested this patch.
entityTypeManager->getExtraFields() not available 


+++ b/src/Form/BetterFieldDescriptionsSettingsForm.php
@@ -87,14 +87,14 @@ class BetterFieldDescriptionsSettingsForm extends ConfigFormBase {
+      $extra_fields = $this->entityTypeManager->getExtraFields('node', $bundle_machine_name, 'form');

This statement causes fatal error, i think you have not tested this patch.
entityTypeManager->getExtraFields() not available

  • Yogesh Pawar committed f78d671 on 8.x-1.x 
    Issue #2870304 by Yogesh Pawar: Removing deprecated entitymanager
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Fixed

Issue fixed & committed to 8.x-1.x branch.
@Pavan B S - please check the patch before uploading also do a dev testing for the patch.

Pavan B S’s picture

Pavan B S commented

@yogesh-pawar thanks for the suggestion i was not knowing to use entityFieldManager for that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.