CommentFileSizeAuthor
#4 auto_username-replace_deprecated_uses-2865145-4.patch2.66 KBbkhandruk
#2 auto_username-replace_deprecated_uses-2865145-2.patch4.22 KBbkhandruk

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
StatusFileSize
new auto_username-replace_deprecated_uses-2865145-2.patch4.22 KB

Replaced deprecated uses in module.

nehajyoti’s picture

nehajyoti commented
Status: Needs review » Needs work

Hello @rocket.man,

Thank you for the contribution.
I reviewed the patch you applied, here are few issues i found:

  • Major issue: Undefined Variable $options in both the files (module and settings form).
  • Minor Issue: Undefined class Database on line 473 for setting form.
bkhandruk’s picture

bkhandruk commented
Status: Needs work » Needs review
StatusFileSize
new auto_username-replace_deprecated_uses-2865145-4.patch2.66 KB

Hello, @nehajyoti.

Thanks for your review. I've fixed both issues you described in #3 and rerolled the patch.

nehajyoti’s picture

nehajyoti commented

Seems to work fine. Applying patch to dev release.

  • nehajyoti committed bdebc1d on 8.x-1.x 
    Issue #2865145 by rocket.man, nehajyoti: Replace deprecated uses
nehajyoti’s picture

nehajyoti commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.