Problem/Motivation

Improves the module help by Updating the Help text page per the HELP standards for Core and Contrib. :-)

Proposed resolution

Write a help text according to https://www.drupal.org/node/632280

Remaining tasks

submit patch / testing

User interface changes

Improves the UI

CommentFileSizeAuthor
#2 2857085-Update_pbt_help-2.patch2.39 KBdbt102

Comments

dbt102 created an issue. See original summary.

dbt102’s picture

dbt102 commented
Assigned: dbt102 » Unassigned
Status: Active » Needs review
StatusFileSize
new 2857085-Update_pbt_help-2.patch2.39 KB
Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community

@dbt102,Thanks! for the patch for the updated Help page,it works well
but i'm still confused for (--) used in below line;

Lightweight Access Control
Permissions by Term restricts user access to specified Drupal nodes based on taxonomy terms--a core part of Drupal’s functionality. PbT lets you restrict content access while relying on very little contributed code.

  • jepSter committed 677179c on 8.x-1.x 
    Issue #2857085 by dbt102, dhwani.addweb: Update_pbt_help
jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented

Thank you! It's always great to get some documentation contribution. I have tweaked the text a bit. Afterwards I have commited it into the latest dev version (https://www.drupal.org/project/permissions_by_term/releases/8.x-1.16). See the Git commit here: http://cgit.drupalcode.org/permissions_by_term/commit/.

The code will go into the next release (8.x-1.17).

Aanal.addweb’s picture

Aanal.addweb commented

@jepSter,Thanks for committing but i didn't get any credit on my Dashboard.

jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented

Oh, no credit - that's a pity. I have followed the guidelines: https://www.drupal.org/node/52287. The standard for Git commit messages is: Issue #[issue number] by [comma-separated usernames]: [Short summary of the change]. Please open an issue in the Git support issue queue, so they can fix this. You should receive credit.

dbt102’s picture

dbt102 commented

@jepSter - thanks for committing the patch and for the work on this cool contrib module.

Per @dhwani.addweb comment (#6), the easiest way to apply the standard for "Commit messages - providing history and credit" is to just copy the git command at the bottom of this issue (under the heading of "Credit & committing", which in this case is

git commit -m 'Issue #2857085 by dbt102, dhwani.addweb: Update_pbt_help' --author="dbt102 "

...

oh, and credit is applied when the issue is closed, since you committed the patch, I've closed the issue

dbt102’s picture

dbt102 commented
Status: Reviewed & tested by the community » Fixed
dbt102’s picture

dbt102 commented
jepster_’s picture

jepster_
Location 🇩🇪Düsseldorf
commented

The code has been released 8.x-1.17.

dbt102’s picture

dbt102 commented

Nice job @jepSter, this is a really cool module!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.