Closed (fixed)
Project:
Crop API
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Feb 2017 at 17:42 UTC
Updated:
5 Apr 2017 at 18:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bkhandruk commentedReplaced all deprecated usages in module.
Comment #3
woprrr commentedThat would be better to use Link::createFromRoute($this->t('View'), 'crop.overview_types'); instead of fromTextAndUrl().
You don't need to change that. Why ? because now have her native implementation of assertEquals() instead KernelTestBase.
IDE show deprecated because KernelTestBase use an deprecated AssertLegacyTrait we need to delete it and use $this->assertEqual of KernelTestBase.
Comment #4
bkhandruk commentedThanks, @woprrr. Corrected link creation and assertion uses. The only thing I've made different from #3 is changed $this->assertEqual (trait method) to $this->assertEquals (KernelTestBase method).
Comment #5
bkhandruk commentedComment #6
woprrr commentedThat look Ok to me :) Thanks for our job @rocket.man ;)
Comment #7
woprrr commentedComment #9
woprrr commentedMerged Thank You for good job.