I'm going to commit this code (have just tested it), but am posting it here as an issue because I know there are onlookers and if they want to comment on the code, that can be done here.

CommentFileSizeAuthor
#2 samlauth-synchronize_name_mail-2855422-2.patch21.88 KBroderik

Comments

roderik created an issue. See original summary.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Needs review
StatusFileSize
new samlauth-synchronize_name_mail-2855422-2.patch21.88 KB

This patch introduces config options (checkboxes in the configuration screen) to synchronize (upstream changes to the) name/e-mail on each login. The code to synchronize name/mail was already there, in synchronizeUserAttributes. ('borrowed' from simplesamlphp_auth.)

But also (in the same patch) I've

  • moved the code to an event subscriber, now that we have events. This way it will be a little bit easier to override the details of behavior around error reporting, for those sites who want to do this. (By the way if you have opinions about whether the default behavior should be different, comments are welcome.)
  • added more code into this function, to do name/e-mail validation.
  • tweaked some details here and there.

  • roderik committed c7895a6 on 8.x-2.x 
    Issue #2855422: sync option for name/e-mail; split code out into event...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Fixed

  • roderik committed 0116559 on 8.x-2.x 
    Issue #2855422 (add-on): minor tweaks to config form.

  • roderik committed 1aaf94e on 8.x-2.x 
    Issue #2855422 - fix synchronization of user name.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.