This will be ongoing. Placeholder for cleanup and refactoring code.

@todo

Remove:
photos_page_title

Cleanup:
notes throughout the code

https://pareview.sh/node/2484

Comments

Nathaniel created an issue. See original summary.

nathaniel’s picture

nathaniel commented

Started to organize functions. Removed a few that were no longer in use. Renamed a couple (_photos_l is now _photos_url, but is not currently in use).

Added to src/: PhotosImage.php, PhotosAlbum.php and PhotosUpload.php to help keep functions organized.

  • Nathaniel committed 7af367f on 8.x-4.x 
    Issue #2850882 by Nathaniel: Some cleanup and refactoring.

  • Nathaniel committed 516f04a on 8.x-4.x 
    Issue #2850882 by Nathaniel: Work on photos album.

  • Nathaniel committed 4331f12 on 8.x-4.x 
    Issue #2850882 by Nathaniel: Work on image and album class.

  • Nathaniel committed d41ab8c on 8.x-4.x 
    Issue #2850882 by Nathaniel: If global settings are disabled size...
nathaniel’s picture

nathaniel commented
Assigned: Unassigned » nathaniel
Issue summary: View changes
Status: Active » Needs work

  • Nathaniel committed ef4c528 on 8.x-4.x 
    Issue #2850882 by Nathaniel: A lot of cleanup. Drupal coding standards....

  • Nathaniel committed 607b9bb on 8.x-4.x 
    Issue #2850882 by Nathaniel: More code cleanup. Drupal standards. Code...

  • Nathaniel committed f47a909 on 8.x-4.x 
    Issue #2850882 by Nathaniel: More code cleanup. Fix comment bug. Fix...

  • Nathaniel committed 738edef on 8.x-4.x 
    Issue #2850882 by Nathaniel: More code sniffer cleanup. Remove JS that...

  • Nathaniel committed 5c5d4a3 on 8.x-4.x 
    Issue #2850882 by Nathaniel: More code cleanup. Remove unused JS.

  • Nathaniel committed 2df74fe on 8.x-4.x 
    Issue #2850882 by Nathaniel: More code cleanup.

  • Nathaniel committed 0e109b3 on 8.x-4.x 
    Issue #2850882 by Nathaniel: Code updates. Mostly dependency injection....

  • Nathaniel committed abc842e on 8.x-4.x 
    Issue #2850882 by Nathaniel: Some cleanup. Move code that requires...

  • Nathaniel committed fa8a35e on 8.x-4.x 
    Issue #2850882 by Nathaniel: More cleanup.

  • Nathaniel committed 4fb1f2e on 8.x-4.x 
    Issue #2850882 by Nathaniel: Update comments and other minor cleanup.

  • Nathaniel committed 218bf99 on 8.x-4.x 
    Issue #2850882 by Nathaniel: Cleanup duplicate in album options.

  • Nathaniel committed 35fa66d on 8.x-4.x 
    Issue #2850882 by Nathaniel: Work on controller dependency injection.

  • Nathaniel committed c1e1e1d on 8.x-4.x 
    Issue #2850882 by Nathaniel: Some cleanup and dependency injection.

  • Nathaniel committed 521dff1 on 8.x-4.x 
    Issue #2850882 by Nathaniel: Add space after default sort link.
nathaniel’s picture

nathaniel commented
Status: Needs work » Fixed

Closing this out. Will open more specific individual issues as needed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.