There's a built-in assumption with this module that the only menu items impacted on those in the Navigation block. However, if you create a custom menu and add a link to the vocabulary index pages to this custom menu block, and then add a new vocabulary with index, this module deletes the existing menu settings, and resets them back to the ones in the Navigation block menu. Since those are disabled, all of the taxonomy term menu items in the custom menu are deleted and you end up with hundreds of orphaned menu items.

You shouldn't make an assumption that everyone uses the Navigation block. It's a real pain to have to repair the menu.

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

I don't quite get what the problem is, but I think I know an easy fix. Currently vocabindex creates a suggested menu item for every index page. This means that as soon as you enable/create an index page, a new menu item to this page is being created. I think this is what causes the problem and deleting this - rarely useful - feature will probably solve it.

For the record: I don't assume anything, it's just a small collision between Vocabulary Index and default Drupal behaviour.

I'll try to fix this sometime soon and I'd be glad if you would test the fix for me.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 6.x-1.1 » 6.x-2.x-dev
Assigned: Unassigned » xano
Status: Active » Fixed

I have changed the hook_menu() implementation. Now menu items to index pages are just callbacks and no longer suggested items. Committed to all development branches.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Assumption about items being in Navigation » Generated menu items break manually added menu items to index pages.
shelleyp’s picture

shelleyp commented

Thanks for incorporating these fixes. However, I'm getting an error when I try the 6.x.2 development module:

user warning: Unknown column 'type' in 'where clause' query: SELECT vi.*, voc.vid, voc.name, voc.description FROM vocabindex vi LEFT JOIN vocabulary voc ON vi.vid = voc.vid WHERE type = 2 AND enabled = 1 ORDER BY voc.name, voc.weight ASC in /home/shelleyp/public_html/realtech/modules/vocabindex/vocabindex.module on line 408.

I did an update, but it doesn't show that any updates occurred.

I'll submit the error as a separate bug.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Closed (fixed) » Postponed (maintainer needs more info)

It seems I found a situation where generated and manually added menu items still collide. I'll keep you posted as soon as I got more info.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Postponed (maintainer needs more info) » Fixed

The problem was still present. If you would create a menu link pointing to a VI page and the module would be disabled or uninstalled, that menu item would remain, but without a destination. Therefore it wouldn't show itself anywhere, so it couldn't be deleted either. Also it would keep its path occupied. I now committed a fix that checks for any manually created menu items pointing to VIs, deletes them and relocates their children to their parent items, so nothing gets lost.

Fixed and committed to 6.x-2.x-dev.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned