Problem/Motivation

In #1446956: Remove the accesslog from statistics access log was removed, but looks like we missed some of the settings.

Proposed resolution

Remove the settings and the schema.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 remove_statistics-2834796-13.patch4.84 KBjibran
#12 remove_statistics-2834796-12.patch4.98 KBjibran
#4 interdiff.txt3.67 KBtimmillwood
#4 2834796-4.patch4.8 KBtimmillwood
#2 access_log.patch1.13 KBtimmillwood

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Active » Needs review
StatusFileSize
new access_log.patch1.13 KB

Initial patch

Status: Needs review » Needs work

The last submitted patch, 2: access_log.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2834796-4.patch4.8 KB
new interdiff.txt3.67 KB

Fixing failing tests and adding upgrade path.

Seems overkill to have an upgrade path test, also because so many other tests fail if the upgrade path isn't there.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Assigned: tedbow » Unassigned
mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Status: Needs review » Needs work

Looks good to me.
One question. Do we always go (in drupal minor versions) from
statistics_update_8002
To
statistics_update_8300

(What when we have D8.10 coming out?).
Could be question is unrelated however. (Setting at needs work however for that one)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review

Mallezie, yes it's documented at https://www.drupal.org/node/2535316

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Status: Needs review » Reviewed & tested by the community

Thanks, (learned something new).
Then this looks great.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 230c5bf and pushed to 8.3.x. Thanks!

diff --git a/core/modules/statistics/statistics.install b/core/modules/statistics/statistics.install
index e2b692c..f232e1d 100644
--- a/core/modules/statistics/statistics.install
+++ b/core/modules/statistics/statistics.install
@@ -85,4 +85,4 @@ function statistics_update_8002() {
  */
 function statistics_update_8300() {
   \Drupal::configFactory()->getEditable('statistics.settings')->clear('access_log')->save();
-}
\ No newline at end of file
+}

Fixed missing new line on commit.

  • alexpott committed 230c5bf on 8.3.x 
    Issue #2834796 by timmillwood: Remove statistics access_log settings
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Updated https://www.drupal.org/node/1900384 to link to this issue too.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new remove_statistics-2834796-12.patch4.98 KB

Uploaded the patch for 8.2.x so that I can use it with 8.2.x. Please ignore this comment.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new remove_statistics-2834796-13.patch4.84 KB

Please ignore the comment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.