I was just wondering whether there were any plans to create a Drupal 8 version of this module or what the general thoughts were on this were?

Thanks,
Stella

CommentFileSizeAuthor
#5 2821707-5-ip_language_negotiation_d8_port.patch18.12 KBstella
#4 ip_language_negotiation_d8_port.patch17.52 KBstella
#3 ip_language_negotiation_d8_port.patch17.43 KBstella

Comments

stella created an issue. See original summary.

BarisW’s picture

BarisW commented

Hi Stella,

I'd love to have a D8 version, but I'm afraid I don't have time to write it myself.
If anyone wants to write a patch, I'm happy to review and commit it.

stella’s picture

stella commented
Category: Plan » Feature request
Status: Active » Needs review
StatusFileSize
new ip_language_negotiation_d8_port.patch17.43 KB

Attached is an initial Drupal 8 port. Only basic testing of it done so far but so far it seems to be working. The only thing I haven't tested at all is how this behaves under caching.

Some reviews and other testing would be nice. :)

stella’s picture

stella commented
StatusFileSize
new ip_language_negotiation_d8_port.patch17.52 KB

Small patch re-roll

stella’s picture

stella commented
StatusFileSize
new 2821707-5-ip_language_negotiation_d8_port.patch18.12 KB

Patch reroll to disable caching on the home page.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. I found some minor bugs, but I'll create follow-up issues for those. Thanks!

  • BarisW committed c183960 on 8.x-1.x authored by stella 
    Issue #2821707 by stella, BarisW: Drupal 8 port?
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Thanks so much for the port Stella. I also made you co-maintainer, in case you want to help out more often with this project :)

stella’s picture

stella commented

Excellent! Thanks! Will hopefully have a site going live soon using this. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.