Comments

Sumit kumar created an issue. See original summary.

Sumit kumar’s picture

Status: Active » Needs review
StatusFileSize
new1.15 KB

added patch for this issue.

berdir’s picture

Status: Needs review » Needs work

Thanks, but you moved the function between an existing function and its documentation. You need to move it and add a standard hook docblock (Implements hook_help())

pivica’s picture

How about adding nice README.md file because this can be used for help also - check https://www.drupal.org/docs/develop/documenting-your-project/module-docu.... On the same page there is example how to reuse README.md file in hook_help() implementation.

amit.drupal’s picture

StatusFileSize
new3.04 KB

Add README.txt file and improve hook_help().

amit.drupal’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: like_and_dislike-2821591-5.patch, failed testing.

amit.drupal’s picture

StatusFileSize
new3.01 KB
amit.drupal’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: like_and_dislike-2821591-5.patch, failed testing.

amit.drupal’s picture

Status: Needs work » Needs review
StatusFileSize
new1.85 KB
new69.26 KB
new1.01 KB

I am not able to include new README.txt file in patch.
submit patch without include README file text.
Upload README.txt file.

Status: Needs review » Needs work

The last submitted patch, 11: like_and_dislike-2821591-11.patch, failed testing.

  • adriancid committed a763c1e on 8.x-1.x authored by amit.drupal
    Issue #2821591 by amit.drupal, Sumit kumar, Berdir, pivica, adriancid:...
adriancid’s picture

Status: Needs work » Fixed

Thanks to @all!, the README.txt file will be added in other issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.