Hi,

Working with FTL(First Time Login), concept is very cool.

Found Some of two dsm warning on code review using coder module. PFA.

Patch to resolve to issue. Please review it.

Thanks,
Harish

CommentFileSizeAuthor
#2 interdiff-2820676-0-2.txt1.2 KBneerajsingh
#2 2820676-2.patch1.21 KBneerajsingh
ftl_codereview.patch1.2 KBharish b
code_review_warnings.png117.88 KBharish b

Comments

harish b created an issue. See original summary.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
StatusFileSize
new 2820676-2.patch1.21 KB
new interdiff-2820676-0-2.txt1.2 KB

Since "check_plain" function only excepts the text that needs to be processed, the patch at issue summary throws an warning saying - "Warning: Illegal offset type in drupal_set_message()".

Re-rolling the patch here with "check_plain" and "t" function.

harish b’s picture

harish b commented
Assigned: harish b » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi neeraj,

Thanks for your review, i checked the patch working properly.

Changing status to RTBC.

Thanks,
Harish.

  • neerajsingh committed 11a0091 on 7.x-2.x 
    Issue #2820676 by harish b, neerajsingh: FTL | Code Review | Warnings
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed the patch to 7.x-2.x-dev

  • neerajsingh committed 11a0091 on 7.x-3.x 
    Issue #2820676 by harish b, neerajsingh: FTL | Code Review | Warnings
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented

Created a feature branch for to add a configurable messages for each role.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.