This task is for a new student in MD Systems, don't do it if it was not assigned to you.

Problem/Motivation

Similar to the #2801043: Include project namespace for module dependencies issue.
Module names are not unique so using just module names for dependencies may get the wrong project.
See #2299747: Project namespaces can now be added for module dependencies for more information.

Proposed resolution

Change the namespaces of the module dependencies.
Combine test dependencies with regular dependencies, no need for test dependencies to be separated.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 include_project-2813721-12.patch1.52 KBVladimirMarko
#12 interdiff-2813721-9-12.txt316 bytesVladimirMarko
#10 interdiff-2813721-#4-#9.txt225 bytesThomas_Buser
#9 include_project-2813721-9.patch1.52 KBThomas_Buser
#7 interdiff-2813721-#4-#6.txt0 bytesThomas_Buser
#6 include_project-2813721-6.patch1.52 KBThomas_Buser
#4 include_project-2813721-4.patch1.52 KBThomas_Buser

Comments

Ginovski created an issue. See original summary.

ginovski’s picture

ginovski commented
Issue summary: View changes
Thomas_Buser’s picture

Thomas_Buser commented
Assigned: Unassigned » Thomas_Buser
Thomas_Buser’s picture

Thomas_Buser commented
Status: Active » Needs review
StatusFileSize
new include_project-2813721-4.patch1.52 KB

Changed info.yml files for the modules dependencies formats

tduong’s picture

tduong commented
Status: Needs review » Needs work

Looks fine :)

Just one nitpick:

+++ b/modules/past_form/past_form.info.yml
@@ -4,5 +4,5 @@ description: 'Captures form submissions and logs them.'
+  - pastdb:past_db

If you look at #2299747: Project namespaces can now be added for module dependencies, it explains how this format should look like.
So project:module, since past_db is a submodule of the past project, this module dependency needs to be fixed.

Thomas_Buser’s picture

Thomas_Buser commented
StatusFileSize
new include_project-2813721-6.patch1.52 KB

+++ b/modules/past_form/past_form.info.yml
- pastdb:past_db changed to past_db:past_db

Thomas_Buser’s picture

Thomas_Buser commented
StatusFileSize
new interdiff-2813721-#4-#6.txt0 bytes

changes in text

Thomas_Buser’s picture

Thomas_Buser commented
Status: Needs work » Needs review
Thomas_Buser’s picture

Thomas_Buser commented
StatusFileSize
new include_project-2813721-9.patch1.52 KB

Weird error didn't save changes, saved now

Thomas_Buser’s picture

Thomas_Buser commented
StatusFileSize
new interdiff-2813721-#4-#9.txt225 bytes
tduong’s picture

tduong commented
Status: Needs review » Needs work 
+++ b/modules/past_form/past_form.info.yml
@@ -4,5 +4,5 @@ description: 'Captures form submissions and logs them.'
+  - past_db:past_db

No, past_db is a submodule of the past project.
If you look at the other issue in the issue summary, you can use the other patch as example, in there there is a similar case for "search_api" and "search_api_db", as search_api_db is a submodule of search_api.

VladimirMarko’s picture

VladimirMarko commented
Assigned: Thomas_Buser » VladimirMarko
Status: Needs work » Needs review
StatusFileSize
new interdiff-2813721-9-12.txt316 bytes
new include_project-2813721-12.patch1.52 KB

As this was as good as done, @tduong told me to just finish it.

There were no test dependencies to combine with regular ones.

tduong’s picture

tduong commented
Status: Needs review » Reviewed & tested by the community

Yes, thanks. Alright, RTBC :)

  • Berdir committed 3b3b0fc on 8.x-1.x authored by VladimirMarko 
    Issue #2813721 by Thomas_Buser, VladimirMarko: Include project namespace...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.