Problem/Motivation

We are having issues with image styles, which are using the focal_point effect. When it comes to config schema checks in tests, we are getting errors that the schema is missing.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 add_image_effect_schema-2812835-3.patch601 bytesbleen
#2 add_image_effect_schema-2812835-2.patch449 byteschr.fritsch

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new add_image_effect_schema-2812835-2.patch449 bytes

Here is a patch

bleen’s picture

bleen commented
StatusFileSize
new add_image_effect_schema-2812835-3.patch601 bytes

Ill be honest, I'm still very uncertain of what needs to be in *.schema.yml but this does seem to mimic what is in image.schema.yml... but if this is needed then we probably need to add the focal_point_crop effect as well.

Take a gander...

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Yes, correct. Sorry, that i missed that, we just had issues with the focal_point_scale_and_crop, because its the only one we use.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Issue tags: +D8Media

  • bleen committed f6d0d8a on 8.x-1.x 
    Issue #2812835 by chr.fritsch, bleen: Add image effect schema
bleen’s picture

bleen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.