Problem/Motivation

Notice: Undefined index: default_tab in Drupal\disqus\Plugin\Block\DisqusCombinationWidgetBlock->buildQuery() (line 40 of disqus/src/Plugin/Block/DisqusCombinationWidgetBlock.php).

Proposed resolution

Fix it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff.txt735 bytesslashrsm
#4 2809443_4.patch730 bytesslashrsm
#2 notice_undefined-2809443-2.patch710 bytesheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: Notice: Undefined index: default_tab in Drupal\disqus\Plugin\Block\DisqusCombinationWidgetBlock->buildQuery() (line 40 of /var/www/drupalvm/web/modules/contrib/disqus/src/Plugin/Block/DisqusCombinationWidgetBlock.php). » Notice: Undefined index: default_tab in Drupal\disqus\Plugin\Block\DisqusCombinationWidgetBlock->buildQuery() (line 40 of /var/www/drupalvm/web/modules/contrib/disqus/src/Plugin/Block/DisqusCombinationWidgetBlock.php)
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new notice_undefined-2809443-2.patch710 bytes
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: Notice: Undefined index: default_tab in Drupal\disqus\Plugin\Block\DisqusCombinationWidgetBlock->buildQuery() (line 40 of /var/www/drupalvm/web/modules/contrib/disqus/src/Plugin/Block/DisqusCombinationWidgetBlock.php) » Notice: Undefined index: default_tab in Drupal\disqus\Plugin\Block\DisqusCombinationWidgetBlock->buildQuery() (line 40)
slashrsm’s picture

slashrsm commented
StatusFileSize
new 2809443_4.patch730 bytes
new interdiff.txt735 bytes

Committed. Thanks!

Fixed a typo while on it. Interdiff and final patch attached.

  • slashrsm committed 1b30b82 on 8.x-1.x authored by heddn 
    Issue #2809443 by slashrsm, heddn: Fix - Notice: Undefined index:...
slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.