Closed (fixed)
Project:
Drupal core
Version:
8.3.x-dev
Component:
phpunit
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Jul 2016 at 13:08 UTC
Updated:
22 Aug 2016 at 09:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
claudiu.cristeaPatch.
Comment #3
claudiu.cristeaComment #4
claudiu.cristeaComment #6
eric_a commentedThis code is in the stable branch.
Comment #7
klausiOnly one minor thing:
use ->assertContains() and ->assertNotContains() instead.
Otherwise makes sense!
Comment #8
martin107 commentedI think the idea behind this issue is good.
BUT From https://www.drupal.org/core/release-cycle-overview
Week of August 3, 2016. 8.2.0-beta1 released and 8.3.x-dev opened.
I suspect this is not a 8.1.x-dev issue anymore.
Comment #9
claudiu.cristeaI think you inverted them :)
Comment #10
martin107 commentedOh crap ... I did ... up is down, down is up :(...
thanks
Comment #12
klausiLooks good! This should go into 8.3.x first, then it is up to the committers to decide whether to cherry pick to the other branches or not.
Comment #13
alexpottGiven that this is a pretty fundamental bug I think we should have this in all branches.
Committed and pushed fdb71536e1f592f52757e14dc7353dbbaaf249f1 to 8.3.x and ae332ad to 8.2.x and 4697702 to 8.1.x. Thanks!