Geocoder Widget: "Cannot read property 'height' of undefined"

Could you resave your view settings and try again? Is this still happening?

I believe this may have been fixed in the latest 8.x-1.6 release that appears to have covered a lot of bugs. I will need to test myself when I have some time, but the root of this problem was related to lines 86 & 87 in the function geolocation.add_map() within the geolocation.js file (in the prior version). The lines in question apply the height/width CSS to the new Map:

$(map.container).css({
  height: map.settings.height,
  width: map.settings.width
});

In the new version, this is located on lines 180 & 181 within the newly named function Drupal.geolocation.addMap() which now look like this:

map.container.css({
  height: map.settings.google_map_settings.height,
  width: map.settings.google_map_settings.width
});

The .height and .width values did not exist on map.settings in the past version because they actually existed on map.settings.google_map_settings. I'm speaking off of memory from a week ago when I ran into this error, but judging by the number of changes & fixes included in the latest version update, I believe this can be marked as fixed. Will confirm when I have some free time.

Ok, the new JS test at #2769305: Add Mink/Javascript test confirms this issue as well as another one. See
https://www.drupal.org/pift-ci-job/380555

Once the test is committed, at least we will potentially notice JS errors earlier.

I have the same issue as @axiaos.

In the file geolocation.js:180, map.settings.google_map_settings is undefined. I'm in 8.x-1.6 version.

It seems that isn't taking the right settings from Drupal.

I will try to debug to find what happens.

@isholgueras,

most of the GoogleMap handling on the PHP side was moved to the GoogleMapsDisplayTrait.php

This especially includes handling the common Google Maps settings that are the same across the GoogleMap Formatter, the GeocoderWidget and the CommonMap views style.

Somewhere along that line, Geocoder isn't properly hooked up to this new functionality.

Yep,

I found that google_map_settings are set on that trait, but when I put a breakpoint there, it doesn't stop.

I will follow that way.

This should do it. Besides fixing this error, it also allows the usual settings on the geocoder widget.

If somebody can confirm this fixing the issue, I will push it.

@derjochenmeyer: if you happen to read this: we should probably also release a new bug-fix-release once this is taken care of.

Added schema definitions. This is non-ideal currently, but I don't know how to avoid repeating those settings over and over in schema.

More schema fixes

I applied the latest patch on simplytest.me. No console errors. Screens look good, works like a charm.

Node edit:

Node view:

I agree, lets put this in a 8.x-1.7 release.

Yes, The patch applies right and now it works perfect.

Thanks

@axaios

as of late, you do need a valid Google API key to use Google Maps. So that second "Missing Key" error is okay and expected. Follow the link mentioned in the error and follow the steps. You can add the API key later to gelocation at /admin/config/services/geolocation

That autocomplete one is more interesting. But will probably be resolved, once the map actually loads, so the search elements can be attached.

The pushed patch contains schema change without any schema update hook.