Currently code needs to call explicitly the saveMetadataToCache method to cache metadata. This creates problems if different modules have different ways to deal with caching.

Let each metadata plugin manage on its own the caching settings about the metadata it handles. Have a general setting at the file_mdm module level. Allow setting to be managed through the admin UI. Metadata is cached by the plugin itself upon ::loadMetadata or ::loadMetadataFromFile calls.

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Assigned: Unassigned » mondrake
StatusFileSize
new24.47 KB
mondrake’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2759357-2.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.1 KB
new25.34 KB
mondrake’s picture

Status: Needs review » Needs work

still a couple of todos, plus ConfigurablePluginInterface is not really needed in FileMetadataPluginInterface.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new3.19 KB
new26.55 KB

one todo less

mondrake’s picture

Status: Needs review » Needs work
mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new6.48 KB
new26.12 KB

removed ConfigurablePluginInterface from FileMetadataPluginInterface

mondrake’s picture

StatusFileSize
new3.99 KB
new26.53 KB
mondrake’s picture

StatusFileSize
new5.86 KB
new31.76 KB

Some more testing for caching.

mondrake’s picture

StatusFileSize
new3.36 KB
new33.37 KB

Two todos more + tests for caching of remote files copied locally

Status: Needs review » Needs work

The last submitted patch, 12: 2759357-12.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new5.16 KB
new36.92 KB

Try this

  • mondrake committed 238897f on 8.x-1.x
    Issue #2759357 by mondrake: Let plugins manage metadata caching
    
mondrake’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.