[node:menu-link] loading first link received when node exists in two menus.

Pretty sure this needs a reroll. Don't forget to set issues with patches to needs review.

[...] forgot about the needs review :(

Again ;).

Here's a test only patch. It creates a node providing a menu link and then creates two menu links from the menu ui linking to this node. The failing test should show that the tokens are replaced with those of one of the manually created menu links.

Here's a combined. It's still failing, locally.

Yes, it's currently randomly failing for me, but that is because your code is only called for chained tokens and I'm testing for [node:menu-link], if I test for [node:menu-link:title], for instance, it's consistently green. Well, I'm not sure why it's randomly failing, but it explains why it should fail. So it's all good, except for (non-chained) menu-link token. I'm currently working on a fix.

I refactored / compacted the code and duplicated it in the logic for [node:menu-link]. I ran the test a couple times and it looks all good to me now. Thanks for reporting this issue @aeotrin and for working on it !

The problem is that the fix assumes that the expected link is the one in the default menu, but there is no gurantee that this is correct. I guess respecting it is more correct than not doing that and we follow the same logic as the UI now.

Given that, I'm fine with this change, but lets document it a bit better. Basically something along the lines of ensuring that we pick the same menu link as the UI would, to be consistent with that.

+++ b/token.tokens.inc
@@ -1117,7 +1117,18 @@ function menu_ui_tokens($type, $tokens, array $data = array(), array $options =
-              $link = reset($links);
+              // Get the menu ui defaults so we can determine what menu was
+              // selected for this node. This ensures that if the node was added
+              // to the menu via the node UI, we use that as a default. If it
+              // was not added via the node UI then grab the first in the
+              // retrieved array.
+              $defaults = menu_ui_get_menu_link_defaults($node);
+              if (isset($defaults['id']) && isset($links[$defaults['id']])) {
+                $link = $links[$defaults['id']];
+              }
+              else {
+                $link = reset($links);
+              }

To prevent duplication create a new method to do as its repeated below.

+++ b/token.tokens.inc
@@ -1204,6 +1204,28 @@ function menu_ui_tokens($type, $tokens, array $data = array(), array $options =
+ * Returns a default link for a given node.
+ *
+ * If the url exists in multiple menus, default to the one
+ * set on the node itself.
+ */
+function _token_get_default_menu_link($node, $links) {

Needs proper @return and @param documentation as well as NodeInterface and array type hints.

Still not sure about the use of "default" menu link, maybe we should go with something like "_token_menu_link_best_match()" or so?

sorry for the delay here. Finally committed now.

PS: The interdiff wasn't actually an interdiff.