An exception thrown by Halite when a key is invalid should be translated to a Key exception.

CommentFileSizeAuthor
#3 2717053-3.patch837 bytesrlhawk

Comments

rlhawk created an issue. See original summary.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Title: Throw Key exception » Throw Encrypt exception

After thinking about this a bit more, I realized that an Encrypt exception should be thrown instead.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Active » Needs review
StatusFileSize
new 2717053-3.patch837 bytes

Here's a patch that translates a thrown InvalidKey exception from Halite into an EncryptException exception.

tynor’s picture

tynor commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • rlhawk committed 1b12579 on 8.x-1.x 
    Issue #2717053 by rlhawk: Throw Encrypt exception
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.