To make the module have exportable config the UUID should be stored.
Blocks #3222715: Properly expose config dependencies in block configuration.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | term_condition-2695141-9.patch | 11.43 KB | rosk0 |
To make the module have exportable config the UUID should be stored.
Blocks #3222715: Properly expose config dependencies in block configuration.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | term_condition-2695141-9.patch | 11.43 KB | rosk0 |
Comments
Comment #2
danielvezaFrom my experience, config for this module is exportable. I know this issue is super old, but do you have any more info to give?
Comment #3
andypostHere's 2 issues
1) no default config in plugin
2) no config schema for plugin
Comment #4
danielvezaHmm. I'm trying to see what I'm missing here. Some more info would be great.
This module provides no config. It only attaches itself to blocks and becomes part of the block config. Because of that I don't see the need for default config or Schema. I can do a bit of research about other conditions in core etc though..
Maybe you can provide a basic patch or some more details about what you expect the module to do, then I can implement them if need be. Otherwise I'll close this for now, since everything seems to be working around the exports in my opinion.
Comment #5
andypostHere's a patch, most of it is clean-up, related docs are https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...
Comment #6
andyposta bit more clean-up
Comment #7
danielvezaWow incredible. Thanks heaps. That was a lot more than I was expecting. This is going to conflict with some other patches I'll be committing this week, so I'll reroll on the latest dev when I'm committed those. Thanks again for the quality work!
Comment #8
xurizaemonI agree that matching terms by UUID, and exporting that instead of tid, is a sensible improvement here. The issue arises when a term is loaded from Default Content and the IDs generated from Default Content are not consistent (while UUIDs from Default Content are).
The patch does some cleanup, but does not appear to replace exporting by tid with exporting by UUID? Am I missing a fine point of config export?
Setting NW since it would now need to target 2.x.
For Sector sites, this will also relate to #3215735: Convert default content to YAML format.
Comment #9
rosk0Please review:
Patch from #6 is not applicable anymore so no interdiff.
Comment #11
dieuweHoping to get this in with the D10 updated. Will do some further testing before tagging a new release.
This should also give a more solid fix to errors with deleted terms as those should be silently dropped by loading via UUID.