To make the module have exportable config the UUID should be stored.

Blocks #3222715: Properly expose config dependencies in block configuration.

Comments

andypost created an issue. See original summary.

danielveza’s picture

Status: Active » Postponed (maintainer needs more info)

From my experience, config for this module is exportable. I know this issue is super old, but do you have any more info to give?

andypost’s picture

Status: Postponed (maintainer needs more info) » Active

Here's 2 issues
1) no default config in plugin
2) no config schema for plugin

danielveza’s picture

Hmm. I'm trying to see what I'm missing here. Some more info would be great.

This module provides no config. It only attaches itself to blocks and becomes part of the block config. Because of that I don't see the need for default config or Schema. I can do a bit of research about other conditions in core etc though..

Maybe you can provide a basic patch or some more details about what you expect the module to do, then I can implement them if need be. Otherwise I'll close this for now, since everything seems to be working around the exports in my opinion.

andypost’s picture

Status: Active » Needs review
StatusFileSize
new3.68 KB

Here's a patch, most of it is clean-up, related docs are https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...

andypost’s picture

StatusFileSize
new724 bytes
new3.62 KB

a bit more clean-up

danielveza’s picture

Wow incredible. Thanks heaps. That was a lot more than I was expecting. This is going to conflict with some other patches I'll be committing this week, so I'll reroll on the latest dev when I'm committed those. Thanks again for the quality work!

xurizaemon’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Needs work

I agree that matching terms by UUID, and exporting that instead of tid, is a sensible improvement here. The issue arises when a term is loaded from Default Content and the IDs generated from Default Content are not consistent (while UUIDs from Default Content are).

The patch does some cleanup, but does not appear to replace exporting by tid with exporting by UUID? Am I missing a fine point of config export?

Setting NW since it would now need to target 2.x.

For Sector sites, this will also relate to #3215735: Convert default content to YAML format.

rosk0’s picture

Title: Store uuid for exportability » Store UUID for exportability
Issue summary: View changes
Status: Needs work » Needs review
Related issues: +#3222715: Properly expose config dependencies in block configuration
StatusFileSize
new11.43 KB

Please review:

  • stores UUID in config
  • adds config schema
  • adds update path
  • fixes coding standards violations in plugin

Patch from #6 is not applicable anymore so no interdiff.

  • dieuwe committed 0bdafb61 on 2.0.x authored by RoSk0
    Issue #2695141 by andypost, RoSk0, DanielVeza, xurizaemon: Store UUID...
dieuwe’s picture

Status: Needs review » Fixed

Hoping to get this in with the D10 updated. Will do some further testing before tagging a new release.

This should also give a more solid fix to errors with deleted terms as those should be silently dropped by loading via UUID.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.