Problem/Motivation

I get an ajax error in views:
Uncaught TypeError: Failed to execute 'contains' on 'Node': parameter 1 is not of type 'Node'.

After the change made in this issue #2561619: Drupal Ajax objects and settings grows endlessly

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edurenye created an issue. See original summary.

edurenye’s picture

Status: Active » Needs review
FileSize
705 bytes

This is the fix from @nod_ that I tested manually and works.

edurenye’s picture

edurenye’s picture

nod_’s picture

Status: Needs review » Reviewed & tested by the community

was rtbc in the other issue

  • catch committed d809e47 on 8.1.x
    Issue #2673824 by edurenye: Ajax error in views
    
catch’s picture

catch’s picture

Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

I failed to mention nod_ in the commit message, sorry nod_. But added to commit credit.

I've committed this to 8.1.x only for now and rolled back the original issue in 8.0.x - this isn't necessarily the only code that got broke.

droplet’s picture

We should check if it should commits to 8.0.x too. Unlike #2561619: Drupal Ajax objects and settings grows endlessly, it's actually a dedicated bug for ajax_view (wrong usage)

** I will check soon but I think @nod_ able to give a quick feedback?

nod_’s picture

Title: Ajax error in views » Views JS passing wrong type of object to Drupal.ajax
Version: 8.1.x-dev » 8.0.x-dev
Status: Fixed » Needs review
Issue tags: +Needs issue summary update

That's a very good point.

Berdir’s picture

+1, that makes sense. No idea why it even works, but there should be no harm in committing this too.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

edurenye’s picture

Version: 8.1.x-dev » 8.0.x-dev

Or should we close the issue? As it was already added to 8.1

Berdir’s picture

Version: 8.0.x-dev » 8.1.x-dev
Status: Needs review » Fixed
Issue tags: -Needs issue summary update

8.0 is only going to get a final security release, yes, so no bugfixes anymore.

TravisCarden’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.