I guess this function used to be called townsec_key_encryption_method_aes. However, it is now called townsec_encrypt_encryption_method_townsec_aes.

Going to attach a patch to correct this. I guess people testing this aren't actually using this encryption method.

Filing as major because it is possible to use another encryption method but still use AKM for key storage. Though for some use cases (needing NIST-certified encryption) it'd be critical.

CommentFileSizeAuthor
#3 townsec_key_2673178_fix_encrypt_callback.patch789 byteswizonesolutions

Comments

wizonesolutions created an issue. See original summary.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Issue summary: View changes
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
StatusFileSize
new townsec_key_2673178_fix_encrypt_callback.patch789 bytes

Here's the patch. Finally, syslog isn't being flooded with warnings anymore (also, the module works).

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Assigned: Unassigned » rlhawk
Status: Active » Needs review
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Assigned: rlhawk » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good, marking RTBC.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.