I've found out that this module defines its own function get_client_ip() to get the client ip address. However, there is already a function provided by drupal core for the same purpose: ip_address()

Is there any explicit reason not using this core function?

CommentFileSizeAuthor
#2 why_not_using_core-2642796-2.patch1.42 KBmalcomio

Comments

pc-wurm created an issue. See original summary.

malcomio’s picture

StatusFileSize
new1.42 KB

Good question - probably just didn't realise it was there.

Here's a patch that uses ip_address() instead.

malcomio’s picture

Status: Active » Needs review

  • malcomio committed a4aa6ae on 7.x-1.x
    Issue #2642796 by malcomio, Елин Й.: Why not using core function...
malcomio’s picture

Status: Needs review » Fixed

Thanks - committed to 7.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.