Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The node comparison currently hides any fields that are not visible in NodeRevisionController::compareNodeRevisions(). Certain use-cases may prefer to compare even hidden fields that have changed.
Proposed resolution
Make this behavior configurable.
Remaining tasks
Review patch, discuss.
User interface changes
API changes
Data model changes
Config schema addition to diff.settings.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | make_the_visible-2635852-7.patch | 3.33 KB | juampynr |
| #7 | make_the_visible-2635852-7.patch | 3.33 KB | juampynr |
| #7 | Selection_003.png | 31.84 KB | juampynr |
| #7 | Selection_002.png | 74.34 KB | juampynr |
| #7 | Selection_001.png | 71.43 KB | juampynr |
Comments
Comment #2
jhedstromComment #3
lhangea commentedI agree, this can be useful in certain situations. I have also added a check-box for that setting in the diff settings page.
This can also be ported in the issue with the generic entity comparison controller.
Comment #4
mikemiles86Comment #5
HezzieB commentedThe description of the test case here needs more details before it can be adequately reviewed.
Comment #6
phenaproximaThis looks pretty good to me, but it would benefit from tests.
Comment #7
juampynr commentedI think that this patch blocks part of the functionality of the module and may confuse site builders. Here is why:
1. The site builder opens the General Settings page and disables the option "Only compare visible fields":
2. Then, when viewing the Article content type settings, this field, which now is useless, is still there:
The site builder could get confused because the action in step 1 should hide the option in step 2. However, I see that the point of using view modes for Diff module is there to let site builders to decide which view mode and which fields they want to show. They can do this at Manage Display.
Based on the above findings, I created a patch that makes the field name at the content type settings more meaningful (see the following screenshot) and adds testing coverage for field visibility when using the Diff view mode.
Comment #9
juampynr commentedThe test fails because there is a missing schema. A fix for this has been added to the patch at #2424233: Add more tests for configurable functionality.
Comment #10
juampynr commentedRe-testing. Tests should pass now.
Comment #12
juampynr commentedTests pass now. Committing.