Problem/Motivation

The PastForm was converted to properly use the Rfc log levels.

Still past.module defines constants.

Proposed resolution

We should either use the Rfc log levels for everything or move our constants to the PastEventInterface.

CommentFileSizeAuthor
#8 past-get_rid_of_severity_constants-2617018-8.patch640 bytestduong
#5 past-get_rid_of_severity_constants-2617018-5.patch15.38 KBtduong
#5 interdiff-2617018-2-5.txt1.42 KBtduong
#2 past-get_rid_of_severity_constants-2617018-2.patch13.77 KBtduong

Comments

mbovan created an issue. See original summary.

tduong’s picture

tduong commented
Status: Active » Needs review
StatusFileSize
new past-get_rid_of_severity_constants-2617018-2.patch13.77 KB

Replaced constants with RfcLogLevel and where they are used.

Status: Needs review » Needs work

The last submitted patch, 2: past-get_rid_of_severity_constants-2617018-2.patch, failed testing.

tduong’s picture

tduong commented
Assigned: Unassigned » tduong
tduong’s picture

tduong commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2617018-2-5.txt1.42 KB
new past-get_rid_of_severity_constants-2617018-5.patch15.38 KB
  • refactored the missing affected files
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Nice thanks.

  • Berdir committed 03e80c0 on 8.x-1.x authored by tduong 
    Issue #2617018 by tduong: Get rid of severity constants
tduong’s picture

tduong commented
Status: Fixed » Needs review
StatusFileSize
new past-get_rid_of_severity_constants-2617018-8.patch640 bytes

Rerolled and fixed the "conflicting constant" added in another issue.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks.

  • Berdir committed 745d24b on 8.x-1.x authored by tduong 
    Issue #2617018 by tduong: Get rid of severity constants

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.