Problem/Motivation

Drupal\views\Plugin\views\style\StylePluginBase misses several docblocks where it inherits from pluginbase.

Proposed resolution

Add the docblocks

Remaining tasks

review

User interface changes

none

API changes

none

Data model changes

none

CommentFileSizeAuthor
#2 2610140.patch1.85 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented

pjonckiere created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Assigned: » Unassigned
Status: Active » Needs review
FileSize
2610140.patch1.85 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -rc eligible

Thanks for the patch! Sorry for the delay in reviewing -- I've been on vacation and no one else, unfortunately, ever reviews docs patches. :(

This looks good! I verified all of these are actually overrides of the base class methods, so inheritdoc is correct.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks again! Added to both 8.x branches.

  • jhodgdon committed c26981d on 8.0.x 
    Issue #2610140 by pjonckiere: Pluginbase inheritdoc blocks

  • jhodgdon committed 4f589b5 on 
    Issue #2610140 by pjonckiere: Pluginbase inheritdoc blocks

(cherry...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.