Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I've just updated Webform Localisation to alpha2.
It has a dependency on Webform 40.11, but the latest version of Webform is currently 40.12. Therefore I can't complete "run updates" successfully.
I've changed the dependency in the .info file tot 40.12, which seems to work fine. Is that Ok?
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2600414-no-explicit-minor-version-13.patch | 736 bytes | Stevel |
| #8 | 2600414-no-explicit-minor-version-8.patch | 738 bytes | Stevel |
| #5 | webform_localization_Dependency_on_webform_4point11-2600414-5.patch | 738 bytes | joseph.olstad |
Comments
Comment #2
joseph.olstadtrue, I will make a patch to test 4.12 asap.
Comment #3
joseph.olstadComment #4
joseph.olstadtest against dev
Comment #5
joseph.olstadComment #6
joseph.olstadComment #7
joseph.olstadHi yazzybe , thanks for reporting. A new release alpha12 depends now on webform 7.x-4.12
Comment #8
Stevel commentedDo we need the exact version number for Webform? Perhaps it would be enough to specify just that it needs to be Webform 4.x, but not the exact minor version?
That way, we don't need to make a new release just because Webform has.
Comment #13
Stevel commentedNew patch starting from the 7.x-4.x branch instead of the latest commit not in that branch.
Comment #14
Stevel commentedBack to needs review...
Comment #15
joseph.olstadactually I think its safer to specify the webform dependency version because 4.13 has not yet been released and we should test it first when it comes out to make sure that it doesn't break compatibility with webform_localization.
4.11 and 4.12 both passed simpletest , but we cannot be 100% confident that 4.13 will not break something that is currently working.
once 4.13 is released we should release 7.x-4.0-alpha13
Comment #16
Stevel commentedI understand your point. It makes sense to try protect users from potential upgrading problems. It does not however prevent them from updating Webform to a later version than specified in the info file.
Most (if not all) updates to Webform however will not break this module. As will most updates to other dependencies (which don't have specific version numbers). It also increases maintenance burden for this module.
I believe it is not very common nor good practice for drupal module to specify specific versions of dependencies just because something might go wrong when the dependency is updated.
Think what would happen if all modules did this: then users could only update after ALL modules with that dependency they use release a simultaneous update.
Comment #18
joseph.olstadThanks Stevel , I've committed your patch.
4.x is now the webforms dependancy rather than 4.11 or 4.12