Problem/Motivation

There is a 'css' property that is documented an initialized but never used.

Proposed resolution

Remove it.

Remaining tasks

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#12 2600012-12.patch1.07 KBjoelpittet
#12 interdiff.txt1.16 KBjoelpittet
#11 css_key_in_batch_set-2600012-11.patch1.48 KBchipway
#8 css_key_in_batch_set-2600012-8.patch466 byteschipway
#2 css_key_in_batch_set-2600012-2.patch1003 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new css_key_in_batch_set-2600012-2.patch1003 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
swentel’s picture

swentel commented
Status: Needs review » Needs work

It seems you can add library though, so should we change the documentation. See batch.inc line 57

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: -rc eligible +Novice

Thanks @swentel, sorry for the delay, lost this one. I agree it's close in doc context to this issue we can probably do that library additions doc here too.

chipway’s picture

chipway commented
StatusFileSize
new css_key_in_batch_set-2600012-8.patch466 bytes

Patch css_key_in_batch_set-2600012-2.patch built for 8.0.x didn't apply on 8.2.x.

Rerolled.

chipway’s picture

chipway commented
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

thanks @chipway, that line form.inc is still there just probably changed for some docs changes in another issue and why it doesn't apply.

Can you try to address @swentel's comment as well?

chipway’s picture

chipway commented
Status: Needs work » Needs review
StatusFileSize
new css_key_in_batch_set-2600012-11.patch1.48 KB

I am not sure what @swentel meant.
Rerolled patch css_key_in_batch_set-2600012-2.patch built for 8.0.x which didn't apply on 8.2.x.
Removed css comment and added "See also #attached ..." to replace it.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new interdiff.txt1.16 KB
new 2600012-12.patch1.07 KB

Thanks @chipway, here's my guess at what @swentel was asking for, does that read well?

chipway’s picture

chipway commented

Thanks @joelpittet. I think you're right and it read well. It is working with batch.inc line 57.

And I tested that 2600012-12.patch apply.

chipway’s picture

chipway commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.2.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 7853618 and pushed to 8.3.x. Thanks!

Tasks go into the next minor release - the documentation fix could be back ported to 8.2.x

  • alexpott committed 7853618 on 8.3.x 
    Issue #2600012 by joelpittet, chipway: 'css' key in batch_set is no...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.