CommentFileSizeAuthor
#7 field_collection_fieldset-remove_button_broken-2599144-3.patch830 bytesGreg Varga
#2 field_collection_fieldset-remove_button_broken-2599144-2.patch2.53 KBtobiasb

Comments

tobiasb created an issue. See original summary.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new field_collection_fieldset-remove_button_broken-2599144-2.patch2.53 KB

I took the most part from field_collection_field_attach_form().

es_es’s picture

es_es commented

tobiasb thank you! Patch working.

drdam’s picture

drdam commented
Status: Needs review » Reviewed & tested by the community

Tested & Reviewed => GO TO RELEASE

  • zestagio committed b851786 on 7.x-2.x authored by tobiasb 
    Issue #2599144 by tobiasb: Remove button broken after Update to 7.x-1.0-...
zestagio’s picture

zestagio commented
Status: Reviewed & tested by the community » Closed (fixed)
Greg Varga’s picture

Greg Varga commented
StatusFileSize
new field_collection_fieldset-remove_button_broken-2599144-3.patch830 bytes

I found a small bug which prevented the last Field Collection Item to be removed.
When creating the "Remove" buttons, the "#max_delta" was set to one less than the required value.
Please see attached patch. (Sorry if not the right format, this is my second patch...)
I also can't reopen the issue.

azovsky’s picture

azovsky commented
Priority: Normal » Critical

Thank you Gergely Varga! Your patch is working!
This fix should be deployed to a new release!