Firstly, great little module, I've been needing something simple like this for a while!

After a bit of a test drive the first issue that comes to mind is that Mobile Detect's isMobile() call returns TRUE for tablets as well as traditional handheld mobile devices. This isn't a problem for most of it's existing use cases, as you can chain rules (so that if isMobile() is TRUE and isTablet() is FALSE the mobile version kicks in) - however Views Mobile hardcodes a single check for isMobile() into the module.

Ideally there would be some way of selecting whether tablets should be included when Views Mobile performs the detection/switch. This could be an extension of the '_mobile' namespace, so that users could also use '_tablet' and '_handheld' (Mobile Detect has implemented an isHandheld() check), or a setting page (either globally via admin/config or even better per-view) where users could select what subset of devices should receive the mobile view.

Any thoughts on what the best way to do this would be?

Comments

Khalor created an issue. See original summary.

khalor’s picture

khalor commented
Issue summary: View changes
revagomes’s picture

revagomes commented

Hi Khalor,
I'm happy that this module helps you.

I've published this module early in order to get feedback from the users and guide the development based on the feedbacks.

If you are familiar with contributing to Drupal, I suggest you to send a patch for this. Otherwise, I'm adding this to the next release. Stay tuned. ;)

Meanwhile you can achieve this by implementing the hook_views_pre_view() and alter the display name to one of your choice. Just as this module does. Don't forget that your custom module must be a weight heavier than views_mobile in order your new hook to run after view_mobile's implementation.

Thanks for the feedback!

jorditr’s picture

jorditr commented

Hi, looks a pretty interesting feature missing on Views. Extending the namespace would be a great addition. Thanks!

bluehead’s picture

bluehead commented

Very cool module. Subscribed.

bluehead’s picture

bluehead commented

Following code works for tablets and handheld devices

/**
 * Implementation of hook_views_pre_view().
 */
function views_mobile_views_pre_view(&$view, &$display_id, &$args) {
  // Change the display if in mobile device.
  $display_id_mobile = $display_id . '_mobile';
  $display_id_tablet = $display_id . '_tablet';

  $has_mobile_mobile = in_array($display_id_mobile, array_keys($view->display));
  $has_mobile_tablet = in_array($display_id_tablet, array_keys($view->display));

  $detect = mobile_detect_get_object();

  if ($detect->isTablet() && $has_mobile_tablet) {
    $view->set_display($display_id_tablet);
  } elseif ($detect->isMobile() && $has_mobile_mobile) {
    $view->set_display($display_id_mobile);
  } 
  return;
}

  • revagomes committed 0fc5e8f on 7.x-1.x 
    Issue #2561593 by bluehead, revagomes: Differentiate between mobile (...
revagomes’s picture

revagomes commented

Thanks @bluehead!

It's already added in the next release.

revagomes’s picture

revagomes commented
Status: Active » Closed (fixed)