Need multiple urls support like in drupal block visibility settings, otherwise need to duplicate same settings for different url.
P.S.: Great module, thanks!

CommentFileSizeAuthor
#2 gd_infinite_scroll-multiple_page_urls-2547465-2.patch4.21 KBalbertski

Comments

dench0 created an issue. See original summary.

albertski’s picture

albertski commented
Title: Multiply pages url » Multiple pages urls
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new gd_infinite_scroll-multiple_page_urls-2547465-2.patch4.21 KB

I also have a lot of urls that need the same settings. I can see a lot of people needing this and creating a new setting for each page doesn't seem like a good work around. This patch adds this feature.

I did the following:

  • Updated gd_infinite_scroll_settings_load_by_url() to use drupal_match_path() to check path (Just like the block module). Don't need separate pattern loops since drupal_match_path() already takes care of patterns.
  • Changed the url admin form to textarea and updated the description.
  • Updated gd_infinite_scroll_validate_url() and removed the pattern checks because drupal_match_path() allows multiple placeholders(*).
delta’s picture

delta commented

Great, thank you, I will review it shortly !
Need to test backward compatibility too.

  • delta committed cd5e4b0 on authored by albertski 
    Issue #2547465 by albertski, delta : Multiple pages urls
delta’s picture

delta commented

Cool, works great, committed. Thanks !

delta’s picture

delta commented
Version: 7.x-1.x-dev » 7.x-1.6
Assigned: dench0 » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.