Add Simple Response object to Microsoft Plugin

+++ b/src/Plugin/tmgmt/Translator/MicrosoftTranslator.php
@@ -96,28 +98,28 @@ class MicrosoftTranslator extends TranslatorPluginBase implements ContainerFacto
+    return AvailableResult::no(t('@translator is not available. Make sure it is properly :configured.'), array('@translator' => $translator->label(), ':configured' => $translator->link(t('configured'))));

:placeholders are for URLs, not for links.

Yes right, fixed.

Oops, this is the right one.

Looks ok.

+++ b/src/Plugin/tmgmt/Translator/MicrosoftTranslator.php
@@ -96,28 +98,31 @@ class MicrosoftTranslator extends TranslatorPluginBase implements ContainerFacto
+  public function checkTranslatable(TranslatorInterface $translator, JobInterface $job) {
+    if (!parent::checkTranslatable($translator, $job)) {
+      return TranslatableResult::no(t('Cannot translate job.'));
     }
     foreach (\Drupal::service('tmgmt.data')->filterTranslatable($job->getData()) as $value) {
       // If one of the texts in this job exceeds the max character count
       // the job can't be translated.
       if (Unicode::strlen($value['#text']) > $this->maxCharacters) {
-        return FALSE;
+        return TranslatableResult::no(t('Cannot translate job.'));
       }
     }
-    return TRUE;
+    return TranslatableResult::yes();
   }

That logic is not correct. The parent doesn't return true/false anymore. Instead, you want to check if the parent returns a unsucessful result and if yes, return that.

Or, if easier, just check the length and then call the parent if that is ok.

And the length check needs to return an actually useful message now, that explains what the problem is.

Yeah, still some room on improving the error message, but this is better than before. Committed.