Problem/Motivation

Since the change from default/external to block1/2/3/4, default values defined in _taboola_get_default_setting() are no longer being used

Proposed resolution

Do one of the following:

  • Remove the default/external settings
  • Refactor to provide default settings for block 1, 2, 3 and 4

Comments

davidgrayston’s picture

davidgrayston commented
Project: Taboola sandbox » Taboola

  • hugronaphor committed 7cfdb67 on 7.x-1.x 
    Issue #2536666: Delete unused _taboola_get_default_setting function, and...
hugronaphor’s picture

hugronaphor commented
Assigned: Unassigned » davidgrayston
Status: Needs work » Needs review
jfcolomer’s picture

jfcolomer commented
Status: Needs review » Closed (fixed)

Looks good for me,
thanks.