Hi,

Congratulations for this very good module.

I bumped into one small issue related to the library version.

I have downloaded the latest 1.1.1 version of the Cloudinary SDK library. Put it in the libraries folder, but I kept getting the "Please make sure the Cloudinary SDK library is installed in the libraries directory." message.

When I debugged it, I found out that in this latest version the place of the "const VERSION..." is on different row and thus the Libraries detection was unable to find the correct version of the library and did not loaded the library.

Below I will attach patch that will address the issue and in addition to it I have added support for the error message that the libraries_load() eventually returns when there is an issue.

Now it will be easier and faster to detect issues like that because the error messages description could be very useful sometimes. For example, the error message when the version number could not be detected is: "The version of the cloudinary library could not be detected.". If I had that I was going to save some time debugging it.

Regards,
Lachezar

Comments

lachezar.valchev’s picture

Status: Needs work » Needs review
StatusFileSize
new4.39 KB

Hi,

Here is the patch.

Regards,
Lachezar

everright’s picture

Hi Lachezar,

I'm so happy to receive the your test and patches, it means that guys have try to use this module.

I will take a review of your patch and test it.

Thank you man!

Thanks
Everright

  • everright committed 2bee311 on 7.x-1.x
    Issue #2499797 by lachezar.valchev: Fixed version detect of Cloudinary...
everright’s picture

This issue fixed with patch "cloudinary-version_fix-2499797-1.patch" which I just replace "t" to "$t" in install file.

I have release a new version 7.x-1.1, please use the new version.

Thanks @Lachezar

everright’s picture

Status: Needs review » Fixed
everright’s picture

Status: Fixed » Closed (fixed)