Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.After enabling and configuring this module, extra CSS gets added to the admin theme (Seven) which completely breaks several UI elements.
The cause would seem to be that on several admin pages, such as admin/modules, the template gets added below the content, regardless of whether a language is already selected. This of course causes Seven to behave in a funky manner because part of its CSS gets overwritten by the CSS which is required by the selection page.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | language_selection_page-2453075-4.patch | 950 bytes | kristiaanvandeneynde |
Comments
Comment #1
stefan.r commented@kristiaanvandeneynde could you provide a patch for this issue?
Comment #2
kristiaanvandeneyndeI could, but currently my schedule is packed.
I reported this in a junior developer's stead.
Comment #3
kristiaanvandeneyndeCannot reproduce so far, will look into what the junior did to get the error.
Comment #4
kristiaanvandeneyndeNever mind, it turns out LSP breaks AJAX calls.
Seeing as we use admin_menu and that module loads the menu through AJAX, every page got mangled when logged in. Patch attached fixes this, although looking at the function language_selection_page_language() makes me wonder whether the whole function should be rewritten. The way it handles its blacklisting doesn't really scream fool proof. This is just at a glance, however.
Comment #5
polComment #7
polHi Kristiaan,
Thanks for your patch.
Have you tested version 2.x ? It's better than 1.x in a lot of way, more than that, 1.x is no more supported, I will commit this patch just to help you, I strongly suggest to switch to 2.x, the patch has been also included in.
Regarding the "The way it handles its blacklisting doesn't really scream fool proof.", it was inspired by the code in the block module, now, feel free to provide us an update for it, I'll be happy to review and commit it asap.
Comment #9
polComment #10
kristiaanvandeneyndeHmm, we actually are running version 2.x, but when writing a patch I must have checked out 1.x. Guess I wasn't paying attention when copy-pasting from the version control tab.
Thanks for committing this, regarding the function: I sadly lack the time to analyze or refactor code in other modules right now :) I'm hardly getting commits done in my own module as it is :(
Comment #11
polOk !
Don't hesitate to report any bug, good luck with your modules too.