Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
FieldGroupRowsWebTest fails currently with PostgreSQL as database backend.
The test fails because the order of results is not guaranteed.
Proposed resolution
The view needs explicit sort fields added to match the expected output of the test.
Remaining tasks
Write patch.
User interface changes
None.
API changes
None.
Beta phase evaluation
Issue category | PostgreSQL Bug |
---|---|
Issue priority | Major |
Prioritized changes | PostgreSQL fix that changes test data only. |
Disruption | None |
Comment | File | Size | Author |
---|---|---|---|
#4 | test_ungroup_rows_missing_order-4.patch | 1.01 KB | bzrudi71 |
Comments
Comment #1
bzrudi71 CreditAttribution: bzrudi71 commentedAnd again, view with no kind of order. Passes PG, let's see if we get pass on MySQL too.
Comment #2
daffie CreditAttribution: daffie commentedIt all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.
So for me it is RTBC.
Good work bzrudi71.
Comment #3
mradcliffeI am not sure what this change is from what is documented in the Issue Summary. It seems to me like this is cruft in the configuration file being removed by re-exporting the view, but I'm not certain.
I think it would best to update the issue summary before setting to RTBC with the patch approach and a little bit more about the problem in those relevant sections.
Comment #4
bzrudi71 CreditAttribution: bzrudi71 commentedAs per @dawehner request in the sister issue #2443695: PostgreSQL: Fix views\Tests\Handler\FieldGroupRowsTest, this patch removes the cache_metadata. An per @mradcliffe request leaves config and module options intact. Doesn't make any difference so. And yes, the export removes that part...
Comment #5
daffie CreditAttribution: daffie commentedIt all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.
All the requested changes are made.
Comment #6
mradcliffeUpdated the issue summary.
Comment #7
mradcliffeAdded beta evaluation to issue summary.
Comment #8
alexpottCommitted aecf0ac and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.