Problem/Motivation

FieldGroupRowsWebTest fails currently with PostgreSQL as database backend.

The test fails because the order of results is not guaranteed.

Proposed resolution

The view needs explicit sort fields added to match the expected output of the test.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category PostgreSQL Bug
Issue priority Major
Prioritized changes PostgreSQL fix that changes test data only.
Disruption None
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bzrudi71’s picture

Status: Active » Needs review
FileSize
1.55 KB

And again, view with no kind of order. Passes PG, let's see if we get pass on MySQL too.

daffie’s picture

Status: Needs review » Reviewed & tested by the community

It all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.
So for me it is RTBC.

Good work bzrudi71.

mradcliffe’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs issue summary update
+++ b/core/modules/views/tests/modules/views_test_config/test_views/views.view.test_ungroup_rows.yml
@@ -1,10 +1,7 @@
-  config:
-    - field.storage.node.field_views_testing_group_rows
...
-    - field

I am not sure what this change is from what is documented in the Issue Summary. It seems to me like this is cruft in the configuration file being removed by re-exporting the view, but I'm not certain.

I think it would best to update the issue summary before setting to RTBC with the patch approach and a little bit more about the problem in those relevant sections.

bzrudi71’s picture

As per @dawehner request in the sister issue #2443695: PostgreSQL: Fix views\Tests\Handler\FieldGroupRowsTest, this patch removes the cache_metadata. An per @mradcliffe request leaves config and module options intact. Doesn't make any difference so. And yes, the export removes that part...

daffie’s picture

Status: Needs review » Reviewed & tested by the community

It all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.
All the requested changes are made.

mradcliffe’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

Updated the issue summary.

mradcliffe’s picture

Issue summary: View changes

Added beta evaluation to issue summary.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed aecf0ac and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed aecf0ac on 8.0.x
    Issue #2452943 by bzrudi71: PostgreSQL: Fix views\Tests\Handler\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.