Add photo functionality to VCard

Added to 7.11. Thank you.

Hi,

I updated the module this morning, from 1.8 to 1.11, and now I get some errors about photo field :

Undefined property: stdClass::$field_address_vcard_photo in field_sql_storage_field_storage_load() (line 406 of ...\modules\field\modules\field_sql_storage\field_sql_storage.module).
and
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_address_vcard_photo' in 'field list': (the query...) in field_sql_storage_field_storage_write() (line 494 of ...\modules\field\modules\field_sql_storage\field_sql_storage.module).
and
Exception: exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_address_vcard_photo' in 'field list'' in ...\includes\database\database.inc:2171 Stack trace: (...)

I think the problem is that the photo field has been added to the schema but no hook_update has been written to support migration from older versions.

I think it's a major issue because updating the module breaks the vcard creation.

Thanks

Thanks, I will look in to it.

Patch to add update hook

Wrong name for the hook... should be vcardfield_field_update_7001, I'm right?

You are right; working to quickly.

I continue to have the same SQL errors. Maybe the update script should update existing vcard fields instances also, or something like that, no?

It should update all vcards. I wonder if it did not fire because the version number is the same with the patch. When you ran update.php did you see anything about vcardfield?

When i ran updb, I seen the update, it seems to have been processed.
The first patch did not triggered update, as the hook was not properly named.

My errors again :

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_address_vcard_photo' in 'field list': (...) in field_sql_storage_field_storage_write() (line 494 of (...)\modules\field\modules\field_sql_storage\field_sql_storage.module).

Exception: exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_address_vcard_photo' in 'field list'' in (...)\includes\database\database.inc:2171 Stack trace: (...)

I had to rework the update, there is no direct update for field schemas.

Hi,

I tried to restore my database two times, at the same state as my production environment, and I get another error now :
Notice : Undefined index: photo dans template_preprocess_vcardfield() (ligne 306 dans (...)\sites\all\modules\contrib\vcardfield\vcardfield.module).

(No more database error)

I get this error several times on each page load (even if no vcard is displayed).

It start to be a problem. Maybe you should revert this "photo" field feature until migration from older version work perfectly. No?
I can't use this version of the module and I need to deploy #2453775 fixe. I think I will revert to a previous version.

Thanks

Please try 7.15, if that does not fix it I will revert until I can test more.

Now I have two errors when I download a vcard

 Notice: Undefined index: middle_name in vcardfield_create_vcard() (line 384 of (...)\sites\all\modules\contrib\vcardfield\vcardfield.module).
Notice: Undefined index: photo in vcardfield_create_vcard() (line 404 of (...)\sites\all\modules\contrib\vcardfield\vcardfield.module).

Sorry but I don't understand why you commit and release a version which you have not properly tested. That's definitely not professional... Non-stable code should not be released as "Recommended".

And you should properly comment your hook_updates, it should not looks like this :

vcardfield module :
  7001 -   Implements hook_update_N().  Add photo field to table
  7002 -   Implements hook_update_N().  Add photo field to table
  7003 -   Implements hook_update_N().  Add photo field to table

Thanks

Tests here have passed. I will add a few more checks in to verify the types of issues you are having.

I made a few adjustments to the code so this works better for updates.

Sorry, I don't have more time to spend on this, I revert on 1.10 and will not update this module anymore.

Did you test 7.16? I ran it through many tests here and the errors are gone and middle name is populating.

Each time I test your code I have to restore a database backup to work from production data, and it takes time, I've done this several times since 2 days and I'm fed up, maybe I will try later... sorry.

Understand, I'm just saying that I trust 7.16 the others were rushed and I know rushed code is bad code. I should not have released until I had time to test as well.