Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In the "Available updates" page, while the Drupal core releases are shown then the "Download" and "Release notes" list items shows unnecessary list style type.
Steps to replicate
- Install Drupal 8 via Git. (https://www.drupal.org/project/drupal/git-instructions)
- Visit "Available updates" page (admin/reports/updates) and see the "Drupal core" updates table rows.
Proposed resolution
Assign stylesheet to the parent element to the list item <ul class="links"></ul> to remove the list styles.
Before/After screenshots
Before
After
Patch #2
Cross browser tests
N.A
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | list-style-inside-ff-and-chrome.jpg | 65.48 KB | corbacho |
| #5 | firefox.jpg | 37.29 KB | corbacho |
| #4 | Available_updates_after_patch_2.png | 65.56 KB | aneek |
| #2 | 2383153-2.patch | 343 bytes | aneek |
| Available_updates_style_issue.png | 66.04 KB | aneek | |
Comments
Comment #1
aneek CreditAttribution: aneek commentedComment #2
aneek CreditAttribution: aneek commentedPatch to fix this issue.
Comment #3
aneek CreditAttribution: aneek commentedComment #4
aneek CreditAttribution: aneek commentedComment #5
corbacho CreditAttribution: corbacho commentedI can replicate it in Chrome 39 Mac.
In Firefox v. 33 Mac, it shows correctly:
This problem comes from a inconsistence of browsers at handling
'list-style-position: outside'(the default position).Reduced test-case: http://jsfiddle.net/HpKvR/2/ (try in firefox Vs Chrome)
Exploring a solution
list-style-position: inside. Fine in Chrome and FF at wide screens. Bad in both browsers with narrow screens. Not tested in IEI think this bug is related to a similar one documented in MDN:
Related to this (since we are using normalize.css library in core), its author does not want to force a list-style-position. So no solution is going to come from normalize.
Conclusion
Because it's difficult to control the look of
list-style-positionacross browsers, I prefer aneek's sane solution (patch #2) and remove completely the bullet points.PS.
From the previous screenshot is obvious that we need increasing
line-height(from 0.9 to 1.4 is my suggestion). Those two links are too close to each other in mobile-view. It's even worse with Bartik as admin theme. It makes it difficult to click with fingers. Should we increase the scope of the issue to include this change?Comment #6
alexpottThis issue is a minor bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 07714ac and pushed to 8.0.x. Thanks!